Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2060 Healthcheck Service Logs Warnings For CDI Eventbus #1970

Merged
merged 1 commit into from
Sep 16, 2017
Merged

PAYARA-2060 Healthcheck Service Logs Warnings For CDI Eventbus #1970

merged 1 commit into from
Sep 16, 2017

Conversation

MattGill98
Copy link
Contributor

No description provided.

@MattGill98
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@Pandrex247
Copy link
Member

Can you prepend PAYARA-2060 to your commit please?
git commit --amend -m PAYARA-2060 Moved stuck-thread remove call into correct method

@Pandrex247 Pandrex247 changed the title Payara 2060 Healthcheck Service Logs Warnings For CDI Eventbus PAYARA-2060 Healthcheck Service Logs Warnings For CDI Eventbus Sep 13, 2017
@MattGill98
Copy link
Contributor Author

jenkins test please

@MattGill98 MattGill98 self-assigned this Sep 14, 2017
@MattGill98 MattGill98 added this to the Payara 174 milestone Sep 14, 2017
@payara-ci
Copy link
Contributor

Quick build and test passed!

mikecroft
mikecroft reviewed Sep 14, 2017
View reviewed changes
Copy link
Contributor

@mikecroft mikecroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Haven't had chance to test it, though. Does it still work if the stuck threads checker is enabled, or would I still get the warning each time?

@MattGill98
Copy link
Contributor Author

It should still work. The stuck thread store is always running and was the component producing the errors. The service just enables or disables the ability to check the store, which shouldn't affect the errors

@smillidge smillidge merged commit dd4badd into payara:master Sep 16, 2017
@Cousjava Cousjava mentioned this pull request Oct 5, 2017
Closed
@MattGill98 MattGill98 deleted the PAYARA-2060-Healthcheck-Service-Logs-Warnings-For-Cdi-Eventbus branch June 18, 2018 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecroft mikecroft mikecroft left review comments

@lprimak lprimak lprimak approved these changes

Assignees

@MattGill98 MattGill98

Labels
None yet
Projects
None yet
Milestone
Payara 4.174
Development

Successfully merging this pull request may close these issues.
7 participants
@MattGill98 @payara-ci @Pandrex247 @lprimak @mikecroft @smillidge @fturizo