PAYARA-1845 move configuration of asadmin recorder to domain from server #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelranaldo
changed the title
|
Jenkins test please |
|
All tests have passed |
Pandrex247
requested changes
Jul 17, 2017
| /> | ||
|
|
||
| <sun:tab id="asadminRecorderConfig" immediate="$boolean{true}" text="$resource{i18nar.asadminRecorder.configuration}" toolTip="$resource{i18nar.asadminRecorder.configurationTip}" > |
There was a problem hiding this comment.
Can you remove the asadminRecorder.configuration and asadminRecorder.configurationTip Strings from the Strings.properties file please? They're no longer needed.
Pandrex247
approved these changes
Jul 18, 2017
|
jenkins test please |
…-1845-move-configuration-of-asadmin-recorder-to-domain-from-server
|
Jenkins test please |
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.