Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-1733-Package-Payara-Public-API-dependency-into-Embedded-editions #1660

Merged
merged 1 commit into from
Jun 8, 2017
Merged

PAYARA-1733-Package-Payara-Public-API-dependency-into-Embedded-editions #1660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion appserver/extras/embedded/web/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
holder.

-->
<!-- Portions Copyright [2016] [Payara Foundation] -->
<!-- Portions Copyright [2016-2017] [Payara Foundation and/or its affiliates] -->

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">

<modelVersion>4.0.0</modelVersion>
Expand Down Expand Up @@ -289,6 +290,14 @@
<type>zip</type>
<optional>true</optional>
</dependency>

<dependency>
<groupId>fish.payara.packager</groupId>
<artifactId>payara-api-package</artifactId>
<version>${project.version}</version>
<type>zip</type>
<optional>true</optional>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this optional? I would have thought this is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cousjava it excludes the transitive dependencies of payara-api-package (note that cascading applies in transitive dependencies), so it only fetches one zip file and extract it.

</dependency>
</dependencies>

<profiles>
Expand Down