Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force static VC runtime #652

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Daniel-Cortez
Copy link
Contributor

@Daniel-Cortez Daniel-Cortez commented May 8, 2021

What this PR does / why we need it:

This PR adds a new compile option FORCE_STATIC_VCRT (enabled by default) to remove the dependency from MSVCR100.dll by building with static MSVC runtime library (see #411).
I borrowed the idea for the name of this option from SDL2, so I believe this name should be common enough.

Which issue(s) this PR fixes:

Fixes #411

What kind of pull this is:

  • A Bug Fix
  • A New Feature
  • Some repository meta (documentation, etc)
  • Other

Additional Documentation:

@Daniel-Cortez Daniel-Cortez requested a review from a team as a code owner May 8, 2021 15:12
@Y-Less
Copy link
Member

Y-Less commented May 8, 2021

That's brilliant timing! I had this issue just yesterday on a new computer.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the state: stale label Jan 9, 2022
@Daniel-Cortez
Copy link
Contributor Author

Daniel-Cortez commented Apr 9, 2022

Removed the "Remove unused duplicate functions from sc1.c" commit, as I'm planning to move it into a separate PR.

@stale stale bot removed the state: stale label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants