Skip to content

Commit

Permalink
Removed dependency between "test" and "jacocoTestReport"
Browse files Browse the repository at this point in the history
Closes issue opensearch-project#2913.

This will allow us to not to exclude the "test" job from every other test.

Unfortunately, this will break creating the coverage reports from only starting "jacocoTestReport" task in Gradle.
  • Loading branch information
pawel-gudel-eliatra committed Jul 5, 2023
1 parent 4eef662 commit e2e1d10
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ jobs:
with:
arguments: |
${{ matrix.gradle_task }} -Dbuild.snapshot=false
-x test
- name: Coverage
uses: codecov/codecov-action@v1
Expand Down
2 changes: 0 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -390,8 +390,6 @@ tasks.withType(JavaCompile) {
}

tasks.test.finalizedBy(jacocoTestReport) // report is always generated after tests run
tasks.jacocoTestReport.dependsOn(test) // tests are required to run before generating the report


allprojects {
tasks.withType(Javadoc).all { enabled = false }
Expand Down

0 comments on commit e2e1d10

Please sign in to comment.