Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include swift files in sources. #60

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

kaomte
Copy link
Contributor

@kaomte kaomte commented Oct 1, 2020

This fixes the 'Unexpected duplicate tasks' by including the image files only in the
bundle.

Pull requests

The easiest way to start contributing is searching open issues by help wanted tag.

  • Add test coverage to the feature or fix if you can. We are more likely to accept new feature pull requests that have related test coverage. This allows us to keep the library stable as we move forward.
  • Remember to document the new feature. We do not accept new feature pull requests without its associated documentation.
  • In case of a new feature please update the example project showing the feature.
  • Please only one fix or feature per pull request. This will increase the chances your feature will be merged.

This fixes the 'Unexpected duplicate tasks' by including the files only in the
bundle.
@kaomte kaomte mentioned this pull request Oct 1, 2020
@pwnstarSmithy
Copy link

@pavankataria @kaomte when do you intend to merge this? it's a major issue.

@pavankataria pavankataria merged commit 993d966 into pavankataria:master Nov 17, 2020
@dkawashima
Copy link

@pavankataria @kaomte How do you use this with CocoaPods? I'm still getting the previous issue as the CocoaPod build has yet to be updated. For Xcode 12, this is a blocker for app release. Is there a way around the CocoaPod build to use something else to get this working. cc @pwnstarSmithy

@pavankataria
Copy link
Owner

pavankataria commented Dec 8, 2020

@dkawashima @kaomte @pwnstarSmithy
image

Please upgrade to the latest version of SwiftDataTables (0.8.2) to receive a fix for this issue. Thank you.

🚀 SwiftDataTables (0.8.2) successfully published on 📅 December 8th, 04:03
👍 Share with your friends and colleagues!

@dkawashima
Copy link

Thank you! updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants