Skip to content

Commit

Permalink
Merge pull request #4 from pavankataria/ScanningDataType
Browse files Browse the repository at this point in the history
Improved sorting algorithm - Automatically Infer the type of the data passed in!
Summary:

Improves the sorting algorithm for columns by scanning the data passed into the SwiftDataTable class and automatically infer the type of the data.
Changes Cell Row Representable to use A new DataTableValueType that moves away from the [[String]] row construction.
Technical:

original initialiser has been moved to a convenience one. users can still inject [[String]] into the SwiftDataTable class: [[String]].
Adds a new DataTableValueType.
Adds a string representation method for DataTableValueType.
Refactors Data Cell and Data CellViewModel to incorporate DataCellTypeValue 724a6f0
Adds a comparable implementation for DataTableValueType 29616b2 & c12ea98
Adds optional initialiser to DataTableValueType to automatically infer the right value type. f3d9d2c
Improves the type detection algorithm for DataTableValueType enum b0254e8
  • Loading branch information
pavankataria authored Mar 13, 2017
2 parents 9069c62 + 0773e63 commit ff3db0d
Show file tree
Hide file tree
Showing 14 changed files with 429 additions and 1,029 deletions.
4 changes: 2 additions & 2 deletions Example/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ PODS:
- Nimble
- Quick
- Quick (1.0.0)
- SwiftDataTables (0.2.6)
- SwiftDataTables (0.2.7)

DEPENDENCIES:
- FBSnapshotTestCase
Expand All @@ -30,7 +30,7 @@ SPEC CHECKSUMS:
Nimble: 415e3aa3267e7bc2c96b05fa814ddea7bb686a29
Nimble-Snapshots: e743439f26c2fa99d8f7e0d7c01c99bcb40aa6f2
Quick: 8024e4a47e6cc03a9d5245ef0948264fc6d27cff
SwiftDataTables: 83d1044c3a7f147dfd3a2e5e1370bc199f4f6441
SwiftDataTables: 16d78aa44825faf00c65ec9678ec51f82d1620a3

PODFILE CHECKSUM: 9948d9c085c4f798f028aaa1e7597151e452280e

Expand Down
4 changes: 2 additions & 2 deletions Example/Pods/Local Podspecs/SwiftDataTables.podspec.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Example/Pods/Manifest.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

378 changes: 191 additions & 187 deletions Example/Pods/Pods.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ff3db0d

Please sign in to comment.