Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checked_add and checked_norm_pdf. #375

Merged
merged 4 commits into from
May 23, 2021
Merged

Add checked_add and checked_norm_pdf. #375

merged 4 commits into from
May 23, 2021

Conversation

schungx
Copy link
Contributor

@schungx schungx commented May 14, 2021 •
edited
Loading

Here it is. Using checked_add for checked_exp.

paupino
paupino requested changes May 21, 2021
View reviewed changes
Copy link
Owner

@paupino paupino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help, and sorry it's taken me a little while to review it!

Some minor changes requested - mainly to keep the public API stable and consistent.

src/maths.rs Outdated Show resolved Hide resolved
src/maths.rs Outdated Show resolved Hide resolved
src/maths.rs Outdated Show resolved Hide resolved
tests/decimal_tests.rs Outdated Show resolved Hide resolved
tests/decimal_tests.rs Outdated Show resolved Hide resolved
@schungx
Copy link
Contributor Author

schungx commented May 22, 2021

@paupino Fixed most of the issues. Pls check.

paupino
paupino approved these changes May 23, 2021
View reviewed changes
Copy link
Owner

@paupino paupino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good. I'll get this merged once all the tests have run.

@paupino paupino merged commit 864c8af into paupino:master May 23, 2021
@paupino paupino mentioned this pull request May 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paupino paupino paupino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schungx @paupino