Skip to content
This repository has been archived by the owner on Oct 29, 2020. It is now read-only.

add ViolationCloseTimer field to NrqlAlertCondition type #75

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

nvaller
Copy link
Contributor

@nvaller nvaller commented Nov 10, 2019

This PR adds ViolationCloseTimer for NRQL Alert Conditions to reflect changes to the API in order to support terraform-providers/terraform-provider-newrelic#157.

Limitations:

  • Does not modify cmd/nrql_alert_conditions.go to use ViolationCloseTimer, as there doesn't appear to be any current means to update NRQL alert conditions through the cli.

Copy link
Contributor

@ctrombley ctrombley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@ctrombley ctrombley merged commit a380ee3 into paultyng:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants