This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
Add TLSClientConfig to default http client #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subsequent terraform PR: |
paultyng
reviewed
Jun 13, 2017
| @@ -16,3 +17,19 @@ func newTestAPIClient(handler http.Handler) *Client { | |||
|
|
|||
| return &c | |||
| } | |||
|
|
|||
| func newTestAPIClientTLSConfig(handler http.Handler) *Client { | |||
There was a problem hiding this comment.
Did you mean to use this in a test somewhere?
There was a problem hiding this comment.
(I realize I never finished my tests)
|
Looks good to me, thest "testing" is at least as good as I did, lol. |
ianrayns
pushed a commit
to ianrayns/go-newrelic
that referenced
this pull request
May 7, 2019
ianrayns
pushed a commit
to ianrayns/go-newrelic
that referenced
this pull request
May 7, 2019
paultyng#3 Make resource_newrelic_alert_condition enabled status configurable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to allow the configuration of a TLSClientConfig to be used on the resty requests made to the new relic api. A subsequent PR made to terraform is to follow.