Fix problem with RTL multiplication, and make it apply to numbers on the right #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultpearson
merged commit a7ea081
into
paultpearson:paultpearson-permutation-context-flag-right-to-left
|
Thank you, Davide. You're truly awesome. I have merged your PR into my branch. I assume that the changes from this merge will get passed on to my PR from my branch to the openwebwork/pg devel branch. Let me know if that's not the case and I will submit another PR from my branch to the openwebwork/pg devel branch. Thanks!!!!!!! |
|
Yup, that's how it works. The PR to openwebwork/pg now contains these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification to openwebwork#481 to fix the problem with the order of cycles in a permutation when
multipleRightToLeftis true. It also makes multiplying a permutation by a number act on the right as well.