pr requested changes

Signed-off-by: Paul Sebastian <[email protected]>
paulstn · Oct 20, 2023 · 5793db0 · 5793db0
1 parent 7f24bf5
commit 5793db0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/public/components/event_analytics/explorer/sidebar/sidebar.tsx b/public/components/event_analytics/explorer/sidebar/sidebar.tsx
@@ -54,13 +54,13 @@ export const Sidebar = (props: ISidebarProps) => {
   const [showFields, setShowFields] = useState<boolean>(false);
   const [searchTerm, setSearchTerm] = useState<string>('');
 
-  // list of every single field object
-  const [allFields, setAllFields] = useState<IField[]>([]);
-
   // method to return the type of a field from its name
   const getFieldTypes = (newFieldName: string) => {
     let fieldType: string = '';
-    allFields.map((field) => {
+    explorerFields.availableFields.map((field) => {
+      if (field.name === newFieldName) fieldType = field.type;
+    });
+    explorerFields.selectedFields.map((field) => {
       if (field.name === newFieldName) fieldType = field.type;
     });
     return fieldType;
@@ -129,17 +129,6 @@ export const Sidebar = (props: ISidebarProps) => {
     [explorerFields, tabId]
   );
 
-  // this useEffect will set allFields when the page is rendered
-  useEffect(() => {
-    if (
-      explorerFields.availableFields.length > 0 &&
-      explorerFields.selectedFields.length === 0 &&
-      allFields.length === 0
-    ) {
-      setAllFields(explorerFields.availableFields);
-    }
-  }, [explorerFields.availableFields]);
-
   const onDragEnd = ({
     destination,
     source,

diff --git a/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx b/...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
@@ -577,7 +577,6 @@ export const DataConfigPanelItem = ({
             {getNumberField('bucketOffset')}
           </>
         )}
-        {/* <EuiSpacer size="m" /> */}
         <div className="vbConfig__content">
           <EuiFlexItem grow={false}>
             <EuiButton