Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube converter error #5

Closed
lunglung876 opened this issue May 13, 2016 · 2 comments · Fixed by #6
Closed

Youtube converter error #5

lunglung876 opened this issue May 13, 2016 · 2 comments · Fixed by #6

Comments

@lunglung876
Copy link

https://github.com/paulredmond/html-to-amp/blob/master/src/Converter/Extensions/YoutubeConverter.php#L36

Argument 2 of createWritableElement() must be array.
@paulredmond
Copy link
Owner

@lunglung876 thank you for the report 👌

paulredmond added a commit that referenced this issue May 30, 2016
@paulredmond
Add Spec for YoutubeConverter Extension
2486541 
Provide a spec for the YoutubeConverter for better test coverage and to
fix regression bug reported in issue #5.

Fixes #5
@paulredmond paulredmond mentioned this issue May 30, 2016
Merged
@paulredmond
Copy link
Owner

Should be fixed in #6. Waiting to hear back on the Travis CI build and then I'll merge 👍

paulredmond added a commit that referenced this issue May 30, 2016
@paulredmond
Add Spec for YoutubeConverter Extension (#6)
91fb7f0 
* Add Spec for YoutubeConverter Extension

Provide a spec for the YoutubeConverter for better test coverage and to
fix regression bug reported in issue #5.

Fixes #5

* OCD Kicking In D:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Spec for YoutubeConverter Extension paulredmond/html-to-amp
2 participants
@paulredmond @lunglung876