Skip to content

Commit

Permalink
Merge pull request #136 from paulocoutinhox/chromium/6694
Browse files Browse the repository at this point in the history
updated to version chromium/6694
  • Loading branch information
paulocoutinhox authored Sep 2, 2024
2 parents cb2b6ec + c4f4a3c commit 579bb9d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docker/android/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN mkdir /build
WORKDIR /build
RUN gclient config --custom-var checkout_configuration=minimal --unmanaged https://pdfium.googlesource.com/pdfium.git
RUN echo "target_os = [ 'android' ]" >> .gclient
RUN gclient sync -r origin/chromium/6689 --no-history --shallow
RUN gclient sync -r origin/chromium/6694 --no-history --shallow

# pdfium reset and clean directories
RUN git -C /build/pdfium reset --hard
Expand Down
2 changes: 1 addition & 1 deletion docker/wasm/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ RUN mkdir /build
WORKDIR /build
RUN gclient config --custom-var checkout_configuration=minimal --unmanaged https://pdfium.googlesource.com/pdfium.git
RUN echo "target_os = [ 'wasm' ]" >> .gclient
RUN gclient sync -r origin/chromium/6689 --no-history --shallow
RUN gclient sync -r origin/chromium/6694 --no-history --shallow

# pdfium reset and clean directories
RUN git -C /build/pdfium reset --hard
Expand Down
3 changes: 3 additions & 0 deletions modules/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ def get_build_args(
args.append("treat_warnings_as_errors=false")
args.append("is_component_build=false")

if config == "release":
args.append("symbol_level=0")

if enable_v8:
args.append("v8_use_external_startup_data=false")
args.append("v8_enable_i18n_support=false")
Expand Down
4 changes: 2 additions & 2 deletions modules/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
task = ""

# pdfium
pdfium_git_branch = "chromium/6689"
# ^ ref: https://pdfium.googlesource.com/pdfium/+/refs/heads/chromium/6689
pdfium_git_branch = "chromium/6694"
# ^ ref: https://pdfium.googlesource.com/pdfium/+/refs/heads/chromium/6694
# OBS 1: don't forget change in android docker file (docker/android/Dockerfile)
# OBS 2: don't forget change in wasm docker file (docker/wasm/Dockerfile)

Expand Down

0 comments on commit 579bb9d

Please sign in to comment.