Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Show number of request on hover #8

Closed
jhm-ciberman opened this issue May 7, 2024 · 5 comments · Fixed by #11
Closed

[Feature Request]: Show number of request on hover #8

jhm-ciberman opened this issue May 7, 2024 · 5 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@jhm-ciberman
Copy link

What happened?

I just deployed this awesome package to production, and it is great! Thanks for the amazing work.

I would like to request if it would be possible to show the number of requests when hovering the mouse. Currently only the max value is shown:

image

Other native charts like the Queues chart or the memory usage chart do display the number when hovering:

image

How to reproduce the bug

.

Package Version

1.1

PHP Version

8.3

Laravel Version

11

Which operating systems does with happen with?

No response

Notes

No response

@jhm-ciberman jhm-ciberman added the bug Something isn't working label May 7, 2024
@paulo-hortelan
Copy link
Owner

Hello and thank you for using my package.

This feature already exists and it's working properly on my projects:

image

However I'm using only Laravel 10, so maybe this is a bug for Laravel 11.

I'll try to reproduce and fix it, but PR are always welcome. Thank you for reporting

@jhm-ciberman
Copy link
Author

Oh, weird. for me it shows only the number of non 2XX requests:

image

This is my artisan about in my prod environment:

forge@XXXXXXXXXX:~/XXXXXXXXX$ php artisan about

  Environment ........................................................................................................
  Application Name ........................................................................................ XXXXXXXXX
  Laravel Version ............................................................................................. 11.6.0
  PHP Version ................................................................... 8.3.3-1+ubuntu22.04.1+deb.sury.org+1
  Composer Version ............................................................................................. 2.7.6
  Environment ............................................................................................. production
  Debug Mode ..................................................................................................... OFF
  URL ............................................................................................. XXXXXXXXXX
  Maintenance Mode ............................................................................................... OFF

  Cache ..............................................................................................................
  Config ...................................................................................................... CACHED
  Events ...................................................................................................... CACHED
  Routes ...................................................................................................... CACHED
  Views ....................................................................................................... CACHED

  Drivers ............................................................................................................
  Broadcasting .................................................................................................. null
  Cache ........................................................................................................ redis
  Database ..................................................................................................... pgsql
  Logs ......................................................................................................... daily
  Mail ...................................................................................................... postmark
  Queue ........................................................................................................ redis
  Session ....................................................................................................... file

  Pulse ..............................................................................................................
  Enabled .................................................................................................... ENABLED
  Version .............................................................................................. v1.0.0-beta16

  Livewire ...........................................................................................................
  Livewire ................................................................................................... v3.4.10

@jhm-ciberman
Copy link
Author

I'm wondering. Could it be that numbers greater than 100 are not shown?

@paulo-hortelan
Copy link
Owner

Don't think so, in my production environment on the last 7 days we have this:

image

Can you create the same scenario using Laravel 10 instead of the 11?

@maciek-szn
Copy link
Contributor

I'm wondering. Could it be that numbers greater than 100 are not shown?

I see this issue with values over 10000.

obraz

obraz

maciek-szn added a commit to maciek-szn/requests-graph-pulse that referenced this issue Aug 10, 2024
When displaying tooltips, they only contain values ​​greater than zero. This is done by filtering:

`.filter(item => item.formattedValue > 0)`

However, `formattedValue` is a string, and additionally - if I understand correctly - formatted according to the user's local settings. This causes situations where values ​​greater than zero are incorrectly filtered out. Therefore, we should refer to the `raw` parameter:

`.filter(item => item.raw> 0)`

Closes paulo-hortelan#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants