a little more accurate Math.cbrt #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1269,7 +1269,13 @@ | |||
| if (value === 0) { return value; } | |||
| var negate = value < 0, result; | |||
| if (negate) { value = -value; } | |||
| result = Math.pow(value, 1 / 3); | |||
| if (value === Infinity) { | |||
There was a problem hiding this comment.
This looks like the code path could be hit with -Infinity too, is that one accurate for the exp + log path?
There was a problem hiding this comment.
-Infinity is converted to Infinity 2 lines above, so the "true" branch will be involved, and the "sign" will be set before return
|
This looks awesome, and your new tests already pass in everything I briefly checked. Can you rebase this on top of the latest master (rather than merge) with (it looks like from your merge commit) |
|
@ljharb , ok, thanks for the command |
ljharb
added a commit
that referenced
this pull request
Apr 14, 2015
a little more accurate Math.cbrt
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #330