Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shutdown race condition work-around #1263

Closed
wants to merge 2 commits into from
Closed

Shutdown race condition work-around #1263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
174eb0d
Add a delay to shutdown after the socket closes to give time for proc…
SeanMollet Sep 27, 2024
6ac6d16
Use a cross platform sleep
SeanMollet Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/impl/tcptransport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,10 @@ void TcpTransport::process(PollService::Event event) {
PLOG_ERROR << e.what();
}

// Allow any received messages to be processed before we shut down and destroy the callbacks
// This should probably be a mutex or check of a queue size or something, but I can't figure out
// what to do that against and a 100ms delay seems to be plenty
std::this_thread::sleep_for(std::chrono::milliseconds(100));
PLOG_INFO << "TCP disconnected";
PollService::Instance().remove(mSock);
changeState(State::Disconnected);
Expand Down
Loading