Add support for setting certificate on PeerConnection #1170
Conversation
There was a problem hiding this comment.
I've no idea why at the moment but MbedTLS fails to parse the certificate in the test.
include/rtc/configuration.hpp
Outdated
| optional<string> certPem; | ||
| optional<string> keyPem; |
There was a problem hiding this comment.
You should make the configuration fields consistent with existing ones in WebSocketConfiguration and WebSocketServerConfiguration. The fields are called certificatePemFile, keyPemFile, and keyPemPass, they allow the user to pass certificate and key either as a file path or as a PEM string.
src/impl/peerconnection.cpp
Outdated
| std::promise<certificate_ptr> cert; | ||
| cert.set_value(std::make_shared<Certificate>(Certificate::FromString(config.certPem.value(), config.keyPem.value()))); | ||
| mCertificate = cert.get_future(); | ||
| } else { |
There was a problem hiding this comment.
You should create the certificate if both certificate and key are not specified, else throw an invalid_argument exception (like in WebSocketServer).
I am also confused, this certificate is created in openssl. |
paullouisageneau
changed the title
paullouisageneau
changed the title
paullouisageneau
changed the title
paullouisageneau
merged commit 16c917f
into
paullouisageneau:master
|
Issue with MbedTLS parsing was preexisting, it is fixed by #1180 |
|
great! |
In Peer B of the WebRTC Direct protocol, a specific certificate and private key need to be specified in order for Peer B to maintain a fixed fingerprint.