Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpusRtpDepacketizer #1123

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

Sean-Der
Copy link
Contributor

Inverse of OpusRtpPacketizer. Takes incoming Opus packets and emits frames.

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thanks for adding! Since Opus and AAC depacketizers are identical, do you want to define both here as suggested?

include/rtc/rtpdepacketizer.hpp Outdated Show resolved Hide resolved
src/rtpdepacketizer.cpp Outdated Show resolved Hide resolved
@Sean-Der

This comment was marked as outdated.

@Sean-Der

This comment was marked as outdated.

@Sean-Der

This comment was marked as outdated.

Sean-Der added 2 commits March 8, 2024 10:15
Depacketizers will include metadata about assembled media.
Inverse of OpusRtpPacketizer. Takes incoming Opus packets and emits
frames.
@Sean-Der
Copy link
Contributor Author

Sean-Der commented Mar 8, 2024

@paullouisageneau I updated with the two changes from other PR

  • Filter bad RTP packets
  • Rename frame_info to frameInfo

ready for a review!

@Sean-Der
Copy link
Contributor Author

Sean-Der commented Mar 8, 2024

Build failure is homebrew HTTP failed respond, nothing to do with code changes

Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, thank you!

@paullouisageneau paullouisageneau merged commit 8c8aa31 into paullouisageneau:master Mar 8, 2024
12 checks passed
@Sean-Der Sean-Der deleted the opus branch April 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants