Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for LDEV-2532 #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cfmitrah
Copy link
Contributor

No description provided.

@paulklinkenberg
Copy link
Owner

Hi, thanks for trying to fix an issue. Unfortunately, there are many issues with it:

  • The code "added" is just a copy-paste of existing code in Action.cfc, with one extra line. Please remove that, and instead improve the existing code.
  • The cflocation does not contain addtoken=false
  • If you do a cflocation, make sure the next page shows the message we wanted to show to the user anyway. For example by adding "&message=....." to the url
  • next time, please add at least a link to the issue mentioned, in your PR text. More logical would have been, to create the issue with this repo.

Thanks for your effort! Paul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants