-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display the video title - add title attribute #88
Conversation
src/lite-yt-embed.css
Outdated
font-family: "YouTube Noto",Roboto,Arial,Helvetica,sans-serif; | ||
color: hsla(0,0%,100%,.9); | ||
text-align: left; | ||
direction: ltr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is a bit overstyled. i want the CSS & JS to be as small as reasonably possible, so i'd like to only include these if totally necessary. Can you whittle these down a bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed extraneous things, and moved styles to ::before element. Also, I changed the background from a base64 encoded svg into a linear-gradient, because the svg isn't stretching correctly when title text expands the element.
Thank you jake! appreciate the fine work here. |
@jakeparis i notice now... That you took the element's (Also I now see some overlap with the intention of playLabel and this title, but the current treatment seems to be OK) Lastly, I know you did this YEARS ago so if you totally forget.. no worries. <3 |
This PR adds a title attribute so the pre-clicked element displays a title. The title's style is basically the same as YouTube's.