This repository was archived by the owner on Jun 12, 2020. It is now read-only.
Don't try to chmod or chown files under /dev #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madddi
force-pushed
the
fix-cron-output-chmod
branch
from
c1ab6f6 to
b4b85db
Compare
|
I've pushed a fix and tested it on my machines. |
|
Looks good to me, thanks for the pull request and noticing this bug, let's see what @paulfantom says :) |
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38 introduced a bug: when using a file as a redirect target for Cron jobs as described in the documentation, the install task will change owner and permissions of this file.
The docs recommend to use
/dev/nullwhen output should be discarded. The task will then change permissions on these files as well, leading to unexpected results.