Skip to content
This repository was archived by the owner on Jun 12, 2020. It is now read-only.

Removed export from template #34

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Removed export from template #34

merged 2 commits into from
Dec 12, 2018

Conversation

ntimo
Copy link

@ntimo ntimo commented Nov 22, 2018

Hello,
I removed the export from the template because it breaks Ubuntu cron files. cron will deactivate the file because its invalid. Also a export is not needed to set a environment variable in a cron file :)

@paulfantom
Copy link
Owner

Heh, export was added since restic didn't work on some platform. It was added in #31. I think this will need testing on non-debian platforms first to settle it once and for all :)

@ntimo
Copy link
Author

ntimo commented Nov 23, 2018

I will test it later today with a Arch Linux VM. And let you know if it works without the export.

@TheLastProject
Copy link
Collaborator

I need to remove the exports too for it to work on Ubuntu 16.04. I think cron may be executed with dash instead of bash there, and export X=y directly is a bashism. However, I didn't need the exports at all for the cron job to work. It's also noticeable in #31 that the original committer apparently reverted this export adding in one of their own branches. So, from my point of view, it doesn't seem necessary to have those exports at all but they break things.

@paulfantom paulfantom merged commit 1965945 into paulfantom:master Dec 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants