Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Astro #554

Closed
paularmstrong opened this issue Jan 16, 2024 · 0 comments · Fixed by #591
Closed

Plugin: Astro #554

paularmstrong opened this issue Jan 16, 2024 · 0 comments · Fixed by #591
Labels
🚀 feature New feature or request 🧩 plugins Official plugins
Milestone
1.0.0

Comments

@paularmstrong
Copy link
Owner

No description provided.

@paularmstrong paularmstrong converted this from a draft issue Jan 16, 2024
@paularmstrong paularmstrong added the 🚀 feature New feature or request label Jan 16, 2024
@paularmstrong paularmstrong added this to the 1.0.0 milestone Jan 16, 2024
@paularmstrong paularmstrong added the 🧩 plugins Official plugins label Jan 20, 2024
paularmstrong added a commit that referenced this issue Jan 31, 2024
@paularmstrong
refactor(core): Workspace commands + passthrough
c106c7e 
Fixes #554
Fixes #555
@paularmstrong paularmstrong mentioned this issue Feb 1, 2024
Merged
3 tasks
paularmstrong added a commit that referenced this issue Feb 1, 2024
@paularmstrong
refactor(core): Workspace commands + passthrough (#591)
b797bba 
**Problem:**

Looking at #554 and #555, there are too many unknowns with passing
through to commands like vite and astro (and webpack, next, etc, for
that matter). It doesn't seem sustainable to attempt to curate plugins
to every single npx command available. Nor does it seem helpful for
users of oneRepo to leave them to need to write the entire passthrough
on their own.

**Solution:**

Passthrough commands. Discussion in #590

**Related issues:**

Fixes #554
Fixes #555

**Checklist:**

- [x] Added or updated tests
- [x] Added or updated documentation
- [x] Ensured the pre-commit hooks ran successfully
@github-project-automation github-project-automation bot moved this from Ready to Done in oneRepo 1.0.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 feature New feature or request 🧩 plugins Official plugins
Projects
oneRepo 1.0.0
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

refactor(core): Workspace commands + passthrough paularmstrong/onerepo
1 participant
@paularmstrong