Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract Cache::AbstractStore into its own file #1

Merged
merged 1 commit into from Apr 13, 2013
Merged

extract Cache::AbstractStore into its own file #1

merged 1 commit into from Apr 13, 2013

Conversation

ghost
Copy link

@ghost ghost commented Apr 13, 2013

This is a subtle style change, but IMO having parent classes like this in separate files is a cleaner approach, especially if they are designed to be inherited from.

@paul
Copy link
Owner

paul commented Apr 13, 2013

I agree, and was planning on doing that once I added a second cache store implementation. But actually, I had no idea anyone else was even using this, so thats awesome.

On Saturday, April 13, 2013 at 2:25 AM, Byron Bowerman wrote:

This is a subtle style change, but IMO having parent classes like this in separate files is a cleaner approach, especially if they are designed to be inherited from.
You can merge this Pull Request by running
git pull https://github.com/BM5k/faraday-cache refactor/abstract-store
Or view, comment on, or merge it at:
#1
Commit Summary
extract Cache::AbstractStore into its own file

File Changes
M lib/faraday/cache.rb (https://github.com/paul/faraday-cache/pull/1/files#diff-0) (1)
A lib/faraday/cache/abstract_store.rb (https://github.com/paul/faraday-cache/pull/1/files#diff-1) (10)
M lib/faraday/cache/memory_store.rb (https://github.com/paul/faraday-cache/pull/1/files#diff-2) (6)

Patch Links:
https://github.com/paul/faraday-cache/pull/1.patch
https://github.com/paul/faraday-cache/pull/1.diff

paul added a commit that referenced this pull request Apr 13, 2013
extract Cache::AbstractStore into its own file
@paul paul merged commit 3f7ba0e into paul:master Apr 13, 2013
@ghost
Copy link
Author

ghost commented Apr 13, 2013

I got here from octokit/octokit.rb#142. I would like to implement caching for octokit in BM5k/ghsb. However, since I am hosting that on heroku, I would prefer a non-memory backend.

I am currently experimenting with adding a redis backend.

@ghost ghost deleted the refactor/abstract-store branch April 14, 2013 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant