[Profiling] Allow paginating all Topn functions (elastic#177926)

This PR fixes a bug where the pagination only shows 2 pages (up to 100 items) in the TopN Functions view. Additionally, the number of items per page are raised from 50 to 100.
paul-tavares · Mar 4, 2024 · d0c8504 · d0c8504
1 parent 9f3bab6
commit d0c8504
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...rvability_solution/profiling/public/components/differential_topn_functions_grid/index.tsx b/...rvability_solution/profiling/public/components/differential_topn_functions_grid/index.tsx
@@ -231,7 +231,7 @@ export function DifferentialTopNFunctionsGrid({
     );
   }
 
-  const rowCount = Math.min(Math.max(sortedBaseRows.length, sortedComparisonRows.length), 100);
+  const rowCount = Math.max(sortedBaseRows.length, sortedComparisonRows.length);
 
   return (
     <>
@@ -303,7 +303,7 @@ export function DifferentialTopNFunctionsGrid({
         }}
         pagination={{
           pageIndex,
-          pageSize: 50,
+          pageSize: 100,
           // Left it empty on purpose as it is a required property on the pagination
           onChangeItemsPerPage: () => {},
           onChangePage,

diff --git a/x-pack/plugins/observability_solution/profiling/public/components/topn_functions/index.tsx b/x-pack/plugins/observability_solution/profiling/public/components/topn_functions/index.tsx
@@ -299,13 +299,13 @@ export const TopNFunctionsGrid = ({
         )}
         columns={columns}
         columnVisibility={{ visibleColumns, setVisibleColumns }}
-        rowCount={sortedRows.length > 100 ? 100 : sortedRows.length}
+        rowCount={sortedRows.length}
         renderCellValue={RenderCellValue}
         sorting={{ columns: [{ id: sortField, direction: sortDirection }], onSort }}
         leadingControlColumns={leadingControlColumns}
         pagination={{
           pageIndex,
-          pageSize: 50,
+          pageSize: 100,
           // Left it empty on purpose as it is a required property on the pagination
           onChangeItemsPerPage: () => {},
           onChangePage,