correctly store basis information in brmsframe objects

paul-buerkner · Jan 29, 2025 · 89f3c86 · 89f3c86
1 parent 9d1acf2
commit 89f3c86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/R/brmsframe.R b/R/brmsframe.R
@@ -36,6 +36,9 @@ brmsframe.brmsterms <- function(x, data, frame = NULL, basis = NULL, ...) {
     x$frame <- frame
     x$frame$re <- subset2(x$frame$re, resp = x$resp)
   }
+  if (!is.null(basis)) {
+    x$frame$basis <- basis[c("resp_levels")]
+  }
   data <- subset_data(data, x)
   x$frame$resp <- frame_resp(x, data = data)
   x$frame$ac <- frame_ac(x, data = data)

diff --git a/R/data-response.R b/R/data-response.R
@@ -83,7 +83,7 @@ data_response.brmsframe <- function(x, data, check_response = TRUE,
   Y <- model.response(model.frame(x$respform, data, na.action = na.pass))
   out <- list(N = N, Y = unname(Y))
   if (is_binary(x$family)) {
-    bin_levels <- x$basis$resp_levels
+    bin_levels <- x$frame$basis$resp_levels
     if (is.null(bin_levels)) {
       bin_levels <- levels(as.factor(out$Y))
     }
@@ -100,7 +100,7 @@ data_response.brmsframe <- function(x, data, check_response = TRUE,
     out$Y <- as.integer(as_factor(out$Y, levels = bin_levels)) - 1
   }
   if (is_categorical(x$family)) {
-    out$Y <- as.integer(as_factor(out$Y, levels = x$basis$resp_levels))
+    out$Y <- as.integer(as_factor(out$Y, levels = x$frame$basis$resp_levels))
   }
   if (is_ordinal(x$family) && is.ordered(out$Y)) {
     diff <- ifelse(has_extra_cat(x$family), 1L, 0L)