Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu - drilldown has children that accessible via keyboard focus but aren't visible #5241

Closed
mcoker opened this issue Nov 16, 2022 · 1 comment · Fixed by #5271
Closed

Menu - drilldown has children that accessible via keyboard focus but aren't visible #5241

mcoker opened this issue Nov 16, 2022 · 1 comment · Fixed by #5271
Assignees
Labels
Milestone

Comments

@mcoker
Copy link
Contributor

mcoker commented Nov 16, 2022

re: patternfly/patternfly-react#7756

It looks like we may be able to fix this in CSS using visibility. It will:

  • behave just like display: none if you set visibility: hidden as far as a11y, effectively hiding it the same way
  • visibility: hidden will leave the element's size/layout in the page - in case we need that, I remember that we needed that for a height calculation?
  • you can set a child of something with visibility: hidden to visibility: visible and it will show that child. something awesome that you can do that you can't with display: none
  • you can transition or animate the visibility property, so adding/removing it could be part of whatever transition/animation we have that slides menus in and out
@mcoker mcoker added the bug label Nov 16, 2022
@mcoker mcoker added this to the 2022.16 milestone Nov 16, 2022
@patternfly-build patternfly-build moved this to Not started in PatternFly Issues Nov 16, 2022
@thatblindgeye thatblindgeye self-assigned this Nov 16, 2022
@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Nov 16, 2022
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues Dec 1, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Dec 6, 2022
@patternfly-build
Copy link

🎉 This issue has been resolved in version 4.222.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants