Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu - drilldown breadcrumb example has unnecessary LI element #7756

Closed
kmcfaul opened this issue Jul 27, 2022 · 1 comment · Fixed by #8433
Closed

Menu - drilldown breadcrumb example has unnecessary LI element #7756

kmcfaul opened this issue Jul 27, 2022 · 1 comment · Fixed by #8433
Assignees
Labels
Milestone

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Jul 27, 2022

When going between the breadcrumb and menu sections while a menu is drilled in, multiple keypresses of Shift+Tab are required to navigate back to the breadcrumbs. What I think might be happening is that focus is shifting back through the parent menus in the DOM which exist but are not visible before hitting the breadcrumb section again. We probably need to manually move focus for this use case instead of relying on default browser behavior.

EDIT from @thatblindgeye : updating this issue to reflect that the breadcrumb drilldown example has a divider wrapped in an li element, without an ul or ol element containing it.

@nicolethoen nicolethoen modified the milestone: Menu Jul 27, 2022
@mcarrano mcarrano added this to the 2022.13 milestone Aug 1, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Aug 16, 2022
@mcarrano mcarrano modified the milestones: 2022.13, 2022.14 Sep 2, 2022
@mcarrano mcarrano modified the milestones: 2022.14, 2023.02 Sep 23, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2022.16 Oct 26, 2022
@nicolethoen
Copy link
Contributor

There's a divider between the breadcrumb and the menu that shouldn't be wrapped in an <li>

@thatblindgeye thatblindgeye moved this from Not started to In Progress in PatternFly Issues Nov 16, 2022
@thatblindgeye thatblindgeye moved this from In Progress to PR Review in PatternFly Issues Dec 8, 2022
@thatblindgeye thatblindgeye changed the title Menu - drilldown to breadcrumb keyboard nav requires multiple keypresses Menu - drilldown breadcrumb example has unnecessary LI element Dec 8, 2022
Repository owner moved this from PR Review to Done in PatternFly Issues Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants