-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Accordion): pulled in Penta updates #9876
feat(Accordion): pulled in Penta updates #9876
Conversation
Preview: https://patternfly-react-pr-9876.surge.sh A11y report: https://patternfly-react-pr-9876-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the sort of update that might need a codemod, right? can we open a codemod issue to track?
AccordionContent - isHidden
was removed.
AccordionToggle - isExpanded
was moved to AccordionItem.
Anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #9851
Confirmed that using the latest alpha locally fixes the border color mismatch between this PR and the core v6 staging.
If we want to wait until #9877 gets merged and pulled into the v6 branch, I can update the new example + tests that were added, otherwise the updates shouldn't be too difficult if done during the merge of main into v6.
Additional issues: