Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Accordion): pulled in Penta updates #9876

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

thatblindgeye
Copy link
Contributor

@thatblindgeye thatblindgeye commented Dec 11, 2023

What: Closes #9851

Confirmed that using the latest alpha locally fixes the border color mismatch between this PR and the core v6 staging.

If we want to wait until #9877 gets merged and pulled into the v6 branch, I can update the new example + tests that were added, otherwise the updates shouldn't be too difficult if done during the merge of main into v6.

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 11, 2023

@thatblindgeye thatblindgeye linked an issue Dec 11, 2023 that may be closed by this pull request
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the sort of update that might need a codemod, right? can we open a codemod issue to track?

AccordionContent - isHidden was removed.
AccordionToggle - isExpanded was moved to AccordionItem.

Anything else?

Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@wise-king-sullyman wise-king-sullyman merged commit e7ebfc0 into patternfly:v6 Jan 4, 2024
10 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion: Consume Penta tokens
8 participants