V6 rebase #9785
Closed
V6 rebase #9785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* chore(Brand): update tests * add more tests * add width test * test updates
* update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…ly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments
* docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…lt (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value
* feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…lease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
* fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps
* chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles
* feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]>
* feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…lease.3 (patternfly#9762) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
* chore(ChipGroup): test revamp * add className * chip group updates, WIP * PR feedback from Eric, added tests * Apply suggestions from code review Co-authored-by: Eric Olkowski <[email protected]> * update onOverflowChipClick test to match onClick * add check for accessibleName --------- Co-authored-by: Eric Olkowski <[email protected]>
* chore(Chip): updated unit tests * Added integration test files * Updated tests per Austin feedback * Tested props get passed to Tooltip * Replaced haveBeenCalledTimes with haveBeenCalled
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* fix(popper): improve flip behavior in RTL * feat(Popper): added prop for the preventOverflow modifier * Update packages/react-core/src/helpers/Popper/Popper.tsx Co-authored-by: Eric Olkowski <[email protected]> * chore(popper): expose preventOverflow option in popperProps interfaces --------- Co-authored-by: Eric Olkowski <[email protected]>
… it (patternfly#9766) * chore(RTL): move RTL helper to utils file, refactor components to use it * chore(helpers): add rtl helper mock
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
…nt length changes (patternfly#9758)
* chore(Checkbox): updated tests * Update packages/react-core/src/components/Checkbox/__tests__/Checkbox.test.tsx Co-authored-by: Eric Olkowski <[email protected]> * chore(checkbox): address PR feedback * chore(checkbox): update default behavior tests to address feedback --------- Co-authored-by: Eric Olkowski <[email protected]>
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* chore(ClipboardCopy): updated tests * Added tests for ClipboardCopy * Removed generated tests, added snapshot * Updated onTooltipHidden test to integration * Separated tooltip and callback tests * Adjusted wait time in cypress * Updated snapshots after rebase * Added tests for non-exported components * Updated per Austin comments
- @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected]
* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]>
- [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected]
* refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * Revert "chore(deps): update dependency ts-patch to v3 (patternfly#9271)" (patternfly#9701) This reverts commit 03985a2. * chore(release): releasing packages [ci skip] - @patternfly/[email protected] * fix: white space change to trigger new prereleases [skip-a11y] * fix: whitespace changes to trigger prereleases (patternfly#9702) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix: Release alphas from v6 and rebase from main (patternfly#9692) * refactor(SliderStep): use token instead for hardcoded value (patternfly#9651) * feat(Drawer): Added start and end to position props, updated resizing to work with RTL (patternfly#9627) * feat(Drawer): Added start and end to position props, updaed resizing to work with RTL * update logic for newsize * fix(Modal): Prevent duplicate ids within Modal (patternfly#9555) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(Brand): update tests (patternfly#9543) * chore(Brand): update tests * add more tests * add width test * test updates * feat(Select) - add appendTo to SelectPopperProps (patternfly#9578) * fix(misc): fixed broken CodeSandbox demos (patternfly#9519) * update import paths * fix(table): update data imports to absolute * fix remaining codesandbox demos * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore: update breadcrumb dropdown item arrow to work in RTL (patternfly#9603) * chore: update breadcrumb dropdown item arrow to work in RTL * chore: use icon with shouldMirrorRTL instead * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Slider): Updated slider to work in RTL. (patternfly#9655) * fix(Slider): Updred slider to work in RTL. Deprecated rightActions and leftActions props, added endActions and startActions props. * fixes from comments * docs(Toolbar): remove test example (patternfly#9614) * docs(tabs): Clean up React documentation content. (patternfly#9606) * docs(tabs):clean up React documentation content. * Update packages/react-core/src/components/Tabs/examples/Tabs.md * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(popper): add start/end positioning with RTL support, update default (patternfly#9628) * fix(popper): add start/end positioning with RTL support, update default * ensure that getLanguageDirection only returns ltr or rtl * fix(Popper): expanded types to include start/end; updated position value * fix(Dropdown): Add appendTo to dropdownPopperProps interface (patternfly#9635) * feat(Timestamp): allowed displayed datetime to be UTC (patternfly#9649) * feat(Timestamp): allowed displayed datetime to be UTC * Updated rendering of default UTC suffix * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(deps): update dependency @patternfly/patternfly to v5.1.0-prerelease.32 (patternfly#9642) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(Tabs): allow RTL scrolling (patternfly#9633) * fix(Tabs): allow RTL scrolling * add direction assignment to update * update aria label descriptions * add props and deprecate old, update internal state names * update desc * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] * fix(Nav): allow RTL scrolling (patternfly#9637) * fix(Nav): allow rtl scrolling * add direction assignment to update * update aria label descriptions * add new props and deprecate old * update desc * update other test snaps * chore(BackgroundImage): update tests (patternfly#9584) * chore(BackgroundImage): update tests * add spread prop test, update test * use styles obj * update test name to use styles * feat(Label) add option to make label clickable (patternfly#9284) * feat(Label) add option to make label clickable * add type to label button * chore(Label): Address misc PR feedback * chore(Label): Remove mention of onClick being incompatible with overflow * chore(Label): Remove prop from effect deps where it's no longer needed --------- Co-authored-by: Austin Sullivan <[email protected]> * feat(charts): add RTL legend support (patternfly#9570) * feat(charts): add RTL legend support * clone data/label components * remove legend positions, add beta * remove last position update * update logic to account for text length * update clones * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(PrimaryDetail): remove primary detail card view require statement (patternfly#9661) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * fix(Draggable): dont disable droppable on false ondrag (patternfly#9646) * chore(release): releasing packages [ci skip] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] * chore(screenshots): Updated screenshots (patternfly#9660) * chore(screenshots): Updated screenshots * rebase and update * fix: dry run publishing v6 alphas --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Titani Labaj <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> * fix: whitespace change to try out dryrun * fix: remove --no-private with dryrun [skip-a11y] * fix: turn off dry run and release alphas [skip-a11y] * chore(release): releasing packages [ci skip] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] - [email protected] - @patternfly/[email protected] - @patternfly/[email protected] - @patternfly/[email protected] --------- Co-authored-by: adamviktora <[email protected]> Co-authored-by: Austin Sullivan <[email protected]> Co-authored-by: patternfly-build <[email protected]> Co-authored-by: kmcfaul <[email protected]> Co-authored-by: Maria <[email protected]> Co-authored-by: Jenny <[email protected]> Co-authored-by: Michael Coker <[email protected]> Co-authored-by: Erin Donehoo <[email protected]> Co-authored-by: Eric Olkowski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominik Petřík <[email protected]> Co-authored-by: Dallas <[email protected]> Co-authored-by: Nicole Thoen <[email protected]>
tlabaj
requested review from
wise-king-sullyman,
mfrances17,
kmcfaul and
thatblindgeye
|
Preview: https://patternfly-react-pr-9785.surge.sh A11y report: https://patternfly-react-pr-9785-a11y.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #9781