Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): updated deps to fix peer conflict in eslint-plugin-pf-react #8656

Conversation

wise-king-sullyman
Copy link
Contributor

What: Closes #7893

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 6, 2023

Comment on lines -109 to -111
"patternfly-react/no-anonymous-functions": "error",
"patternfly-react/no-anonymous-functions": "off",
"prefer-const": "error",
"prettier/prettier": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled these rules temporarily as changes to linting deps are now causing a lot of errors to be thrown. I've created #8657 and #8658 as followup issues.

@nicolethoen nicolethoen linked an issue Feb 7, 2023 that may be closed by this pull request
@nicolethoen
Copy link
Contributor

nicolethoen commented Feb 8, 2023

@wise-king-sullyman - just need to resolve conflicts

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once conflicts are resolved.

@wise-king-sullyman wise-king-sullyman force-pushed the eslint-plugin-pf-react-conflicting-deps branch from 8567ac3 to 2941015 Compare February 8, 2023 14:06
@wise-king-sullyman wise-king-sullyman force-pushed the eslint-plugin-pf-react-conflicting-deps branch from 2941015 to ad9c0e7 Compare February 8, 2023 14:29
@tlabaj tlabaj merged commit 0534f6a into patternfly:v5 Feb 9, 2023
@wise-king-sullyman wise-king-sullyman deleted the eslint-plugin-pf-react-conflicting-deps branch February 9, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-patternfly-react conflicting dependencies
5 participants