Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Page): updated onPageResize prop to undefined default #8203

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix(Page): updated onPageResize prop to undefined default #8203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-core/src/components/Page/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export class Page extends React.Component<PageProps, PageState> {
isManagedSidebar: false,
isBreadcrumbWidthLimited: false,
defaultManagedSidebarIsOpen: true,
onPageResize: (): void => null,
mainTabIndex: -1,
isNotificationDrawerExpanded: false,
onNotificationDrawerExpand: () => null,
Expand Down
26 changes: 13 additions & 13 deletions packages/react-core/src/components/Page/__tests__/__snapshots__/Page.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ exports[`Page Check dark page against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -65,7 +65,7 @@ exports[`Page Check page horizontal layout example against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -129,7 +129,7 @@ exports[`Page Check page to verify breadcrumb is created - PageBreadcrumb syntax
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -296,7 +296,7 @@ exports[`Page Check page to verify breadcrumb is created 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -463,7 +463,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - new components s
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -749,7 +749,7 @@ exports[`Page Check page to verify grouped nav and breadcrumb - old / props synt
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1040,7 +1040,7 @@ exports[`Page Check page to verify nav is created - PageNavigation syntax 1`] =
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1219,7 +1219,7 @@ exports[`Page Check page to verify skip to content points to main content region
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
data-testid="page-test-id"
id="PageId"
>
Expand Down Expand Up @@ -1394,7 +1394,7 @@ exports[`Page Check page vertical layout example against snapshot 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1455,7 +1455,7 @@ exports[`Page Sticky bottom breadcrumb on all height breakpoints - PageBreadcrum
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1622,7 +1622,7 @@ exports[`Page Verify sticky bottom breadcrumb on all height breakpoints 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1789,7 +1789,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints - PageBread
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down Expand Up @@ -1956,7 +1956,7 @@ exports[`Page Verify sticky top breadcrumb on all height breakpoints 1`] = `
<DocumentFragment>
<div
aria-label="Page layout"
class="pf-c-page pf-m-resize-observer pf-m-breakpoint-default pf-m-height-breakpoint-sm my-page-class"
class="pf-c-page my-page-class"
id="PageId"
>
<header
Expand Down