fix(DataListCheck): assign checked prop to correct attribute #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-7163.surge.sh A11y report: https://patternfly-react-pr-7163-a11y.surge.sh |
jenny-s51
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Nice updates @thatblindgeye ! Props work as expected and updated prop descriptions look great. When both checked and isChecked are used on DataListCheck, the console warning also makes it clear that the user should only use one of these props. 👍
This was referenced Apr 21, 2022
jelly
added a commit
to jelly/cockpit-machines
that referenced
this pull request
Sep 9, 2024
Was temporary required due to a PF bug which was fixed long ago. patternfly/patternfly-react#7163 Related: cockpit-project/cockpit#20973
jelly
added a commit
to cockpit-project/cockpit-machines
that referenced
this pull request
Sep 12, 2024
Was temporary required due to a PF bug which was fixed long ago. patternfly/patternfly-react#7163 Related: cockpit-project/cockpit#20973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #6762
Based on the latest update to the DataListCheck component, I changed the attribute to which the
checkedprop was assigned. Having thecheckedattribute on the input element be either of theisCheckedorcheckedprops was causing the behavior seen in the linked issue (a console warning of changing from uncontrolled to controlled, or vice versa).With this update, a console warning should only occur if both
checkedandisCheckedprops are passed in (which I've noted not to do in the prop descriptions). EDIT: this warning may only appear when testing in a local workspace and may not appear in the preview build.If
checkedis passed in, then it's assigned to the correctdefaultCheckedattribute (previously being assigned to the checked attribute was the reason why the checkbox wasn't updating visually, as it wasn't updating at all I believe). If neither prop is passed in, then the component should act as a normal uncontrolled checkbox.Additional issues: