Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Select): add disabled flag for component #2678

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Aug 9, 2019

What: Adds isDisabled flag to select.

Refer to issue: #2366

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Aug 9, 2019

Requires core to be updated to v2.26 to get styling, in #2668

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2678.surge.sh

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a typo to fix

mcoker
mcoker previously approved these changes Aug 9, 2019
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @kmcfaul! 🥇

tlabaj
tlabaj previously approved these changes Aug 9, 2019
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

constructor(props) {
super(props);
this.options = [
{ value: 'Alabama', disabled: false },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the disabled keys from the options array in the two added examples for clarity purposes

Copy link
Contributor

@tlabaj tlabaj Aug 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking they same thing. But thought it was fine. You are right though, it would be more clear.

jessiehuff
jessiehuff previously approved these changes Aug 9, 2019
Copy link
Contributor

@jessiehuff jessiehuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Copy link
Collaborator

@jschuler jschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about instead of adding more examples just to demonstrate this, add a checkbox to an existing example that can toggle isDisabled?

@tlabaj tlabaj added PF4 labels Aug 9, 2019
@tlabaj
Copy link
Contributor

tlabaj commented Aug 9, 2019

@jschuler , I think the examples are fine as is. They match core.

@kmcfaul kmcfaul dismissed stale reviews from jessiehuff and tlabaj via 5d8e002 August 9, 2019 20:45
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler jschuler merged commit a72124f into patternfly:master Aug 9, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants