Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Pagination): Fix pagination to update page count #2639

Merged
merged 4 commits into from
Aug 6, 2019
Merged

fix(Pagination): Fix pagination to update page count #2639

merged 4 commits into from
Aug 6, 2019

Conversation

jessiehuff
Copy link
Contributor

Fixes #2629

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 5, 2019
@AllenBW
Fix page offset bug, simplify ruletable pagination
9164750 
includes patternfly/patternfly-react#2639
@AllenBW AllenBW mentioned this pull request Aug 5, 2019
Merged
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2639.surge.sh

@AllenBW
Copy link
Contributor

AllenBW commented Aug 5, 2019 •
edited
Loading

The only issue with this is... now yah can't change the date via input :(

@jessiehuff
Copy link
Contributor Author

@AllenBW I was trying to look into this, but I'm not positive I know what you mean. Can you explain further or show me what's happening for you? I'll definitely work on whatever is going on! :)

@AllenBW
Copy link
Contributor

AllenBW commented Aug 5, 2019

@jessiehuff hi!! I believe its the same issue we see in the test failure, if i drop into the PatternFly-React preview and attempt to change the page via the input (rather than the flanking page buttons) there is no change in page value 😬

@AllenBW
Copy link
Contributor

AllenBW commented Aug 5, 2019

#2417 Is definitely the work that resulted in this issue, another fe (in addition to insights) that demonstrates this issue is https://cloud.redhat.com/beta/rhel/vulnerability/cves so you'll update the top pagination and the bottom one will not reflect the changes

AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Aug 5, 2019
@AllenBW
Fix page offset bug, simplify ruletable pagination (#390)
e549b64 
includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
Fix page offset bug, simplify ruletable pagination (#390)
20938c8 
includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
Fix page offset bug, simplify ruletable pagination (#390)
3986efc 
includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 5, 2019
Fix page offset bug, simplify ruletable pagination (#390)
dda9eb5 
includes patternfly/patternfly-react#2639
@dlabaj dlabaj added the PF4 label Aug 5, 2019
dlabaj
dlabaj reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessiehuff Looks like the jest tests are failing.

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 5, 2019
@AllenBW
Eliminate duplicate fetches, functional component listens to props
41b0890 
includes patternfly/patternfly-react#2639
@jessiehuff
Copy link
Contributor Author

Hey @AllenBW! I think I got it figured out. :) Sorry it took me so long, I had issues with my development environment that I had to solve first haha. Thanks for pointing out the issue!

@AllenBW
Copy link
Contributor

AllenBW commented Aug 5, 2019

WOOHOO!! thanks for effort! lookin forward to incorporating this fix 😋 💃🏾🌺

@dlabaj dlabaj merged commit ff9c745 into patternfly:master Aug 6, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

AllenBW added a commit to AllenBW/insights-advisor-frontend that referenced this pull request Aug 6, 2019
@AllenBW
Eliminate duplicate fetches, functional component listens to props
903063a 
includes patternfly/patternfly-react#2639
AllenBW added a commit to RedHatInsights/insights-advisor-frontend that referenced this pull request Aug 6, 2019
@AllenBW
Eliminate duplicate fetches, functional component listens to props (#391
0a8866b 
)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
571a891 
…391)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
df17102 
…391)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
1478176 
…391)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
a2a7cf6 
…391)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
c61c032 
…391)

includes patternfly/patternfly-react#2639
ryelo pushed a commit to RedHatInsights/insights-advisor-frontend-build that referenced this pull request Aug 6, 2019
Eliminate duplicate fetches, functional component listens to props (#…
f4c5532 
…391)

includes patternfly/patternfly-react#2639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priley86 priley86 priley86 approved these changes

@dlabaj dlabaj dlabaj approved these changes

@redallen redallen redallen approved these changes

@rebeccaalpert rebeccaalpert Awaiting requested review from rebeccaalpert

@tlabaj tlabaj Awaiting requested review from tlabaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PF4 Pagination doesn't update page count
6 participants
@jessiehuff @patternfly-build @AllenBW @priley86 @dlabaj @redallen