Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Select): add select custom filter callback #2434

Merged
merged 5 commits into from
Jul 29, 2019
Merged

feat(Select): add select custom filter callback #2434

merged 5 commits into from
Jul 29, 2019

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Jul 2, 2019

What: Adds a custom callback for the filtering function used in typeahead variants. This replaces the current search entirely, so the function must handle filtering the list of children/options and return the filtered results for the internal state to update.

Additional issues: #2369

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2434.surge.sh

@tlabaj tlabaj requested review from jschuler and dlabaj July 3, 2019 19:50
@kmcfaul kmcfaul force-pushed the select-custom-filter branch from 4ef3717 to 6e3c6b0 Compare July 12, 2019 15:39
tlabaj
tlabaj previously approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tlabaj
tlabaj previously approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jschuler
Copy link
Collaborator

LGTM, but noticed two other things:

  1. When i type something and filter down the results, and then close and reopen the dropdown (the filter text is still applied) it shows me the whole list again. Is this expected?
  2. When i start typing and the dropdown is closed, it does not automatically open. I would expect it to open

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Jul 26, 2019

  1. When you close the menu the filter resets. If you select an item, that is filled into the input but it isn't acting as a filter, and maybe that should change?

  2. is being addressed in a separate PR

@kmcfaul kmcfaul force-pushed the select-custom-filter branch from 3e39d49 to fee95bd Compare July 26, 2019 15:48
tlabaj
tlabaj approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 878a107 into patternfly:master Jul 29, 2019
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@karelhala karelhala mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redallen redallen redallen left review comments

@jschuler jschuler jschuler approved these changes

@tlabaj tlabaj tlabaj approved these changes

@dlabaj dlabaj Awaiting requested review from dlabaj

Assignees

@jschuler jschuler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kmcfaul @patternfly-build @jschuler @tlabaj @redallen