Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Stack): Convert stack to typescript #2412

Merged
merged 9 commits into from
Jul 5, 2019

Conversation

jessiehuff
Copy link
Contributor

@jessiehuff jessiehuff commented Jul 1, 2019

Fixes #2411
Fixes #2144

@dlabaj dlabaj added Demo PF4 and removed Demo labels Jul 1, 2019
@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://patternfly-react-pr-2412.surge.sh

rebeccaalpert
rebeccaalpert previously approved these changes Jul 1, 2019
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

redallen
redallen previously approved these changes Jul 2, 2019
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit a1c34b6 into patternfly:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants