chore(Switch): convert Switch to TypeScript #2311
Conversation
|
PatternFly-React preview: https://patternfly-react-pr-2311.surge.sh |
packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Outdated
Show resolved
Hide resolved
| /** A callback for when the Switch selection changes. (isChecked, event) => {} */ | ||
| onChange: PropTypes.func, | ||
| onChange?(checked: boolean, event: FormEvent<HTMLInputElement>): void; |
There was a problem hiding this comment.
Use an arrow function so the docs pick this up properly. Like `onChange?: (checked: boolean, event: FormEvent) => void;
packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Outdated
Show resolved
Hide resolved
| 'aria-label': '' | ||
| }; | ||
| export class Switch extends React.Component<SwitchProps> { | ||
| id = ''; |
There was a problem hiding this comment.
Remove this class attribute
There was a problem hiding this comment.
Not sure what the purpose of this id is ... is it suppose to be the same as props.id?
There was a problem hiding this comment.
it instantiates the id when it is generated. And there is no id prop set.
There was a problem hiding this comment.
Shouldn't it instantiate it as a defaultProp to getUniqueId()?
There was a problem hiding this comment.
I am not sure. Does it work differently in TS than JS. In JS if you set defaultProp to getUniqueId, if you had more hat one Switch on the page the id's would all be the same? That is why we had it in the constructor before.
There was a problem hiding this comment.
Looks like it will set it for all of the name to be the same based off the time. Leave it in the constructor.
packages/patternfly-4/react-core/src/components/Switch/Switch.tsx
Outdated
Show resolved
Hide resolved
| 'aria-label': '' | ||
| }; | ||
| export class Switch extends React.Component<SwitchProps> { | ||
| id = ''; |
There was a problem hiding this comment.
Not sure what the purpose of this id is ... is it suppose to be the same as props.id?
| 'aria-label': '' | ||
| }; | ||
| export class Switch extends React.Component<SwitchProps> { | ||
| id = ''; |
There was a problem hiding this comment.
Looks like it will set it for all of the name to be the same based off the time. Leave it in the constructor.
#2019
What:
Additional issues: