-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-styles): move react styles #2085
Conversation
PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2085 +/- ##
==========================================
+ Coverage 80.31% 80.83% +0.52%
==========================================
Files 651 651
Lines 8300 8260 -40
Branches 628 628
==========================================
+ Hits 6666 6677 +11
+ Misses 1333 1282 -51
Partials 301 301
Continue to review full report at Codecov.
|
@redallen Looks like there's a conflict with .babelrc |
PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh |
What: Change all the React css imports and add types for them. Instead of using a babel plugin to generate the JS at compile time for our CSS-in-JS solution, we statically generate it beforehand in react-styles.
Additional issues: