Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-styles): move react styles #2085

Merged
merged 28 commits into from
Jun 5, 2019
Merged

Conversation

redallen
Copy link
Contributor

@redallen redallen commented May 24, 2019

What: Change all the React css imports and add types for them. Instead of using a babel plugin to generate the JS at compile time for our CSS-in-JS solution, we statically generate it beforehand in react-styles.

Additional issues:

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh

@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #2085 into master will increase coverage by 0.52%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
+ Coverage   80.31%   80.83%   +0.52%     
==========================================
  Files         651      651              
  Lines        8300     8260      -40     
  Branches      628      628              
==========================================
+ Hits         6666     6677      +11     
+ Misses       1333     1282      -51     
  Partials      301      301
Flag Coverage Δ
#patternfly3 85.22% <ø> (ø) ⬆️
#patternfly4 76.45% <100%> (+0.97%) ⬆️
#patternflymisc 95.68% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...ernfly-4/react-core/scripts/snapshot-serializer.js 100% <ø> (ø)
...4/react-core/src/components/Select/SingleSelect.js 81.25% <ø> (ø) ⬆️
...rc/components/Table/utils/decorators/classNames.js 75% <ø> (ø) ⬆️
...atternfly-4/react-core/src/components/Tabs/Tabs.js 80.76% <ø> (ø) ⬆️
...react-core/src/components/DataList/DataListCell.js 100% <ø> (ø) ⬆️
...-4/react-core/src/components/Dropdown/Separator.js 100% <ø> (ø) ⬆️
...act-core/src/components/Dropdown/DropdownToggle.js 85.71% <ø> (ø) ⬆️
...rnfly-4/react-core/src/components/Select/Select.js 58% <ø> (ø) ⬆️
...ponents/ApplicationLauncher/ApplicationLauncher.js 50% <ø> (ø) ⬆️
...ct-core/src/components/ClipboardCopy/CopyButton.js 100% <ø> (ø) ⬆️
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b4d91...6531d73. Read the comment docs.

dlabaj
dlabaj previously approved these changes May 28, 2019
@dlabaj
Copy link
Contributor

dlabaj commented May 28, 2019

@redallen Looks like there's a conflict with .babelrc

@patternfly-build
Copy link
Contributor

PatternFly-React preview: https://2085-pr-patternfly-react-patternfly.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants