-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Badge): Convert badge to typescript #2048
Conversation
PatternFly-React preview: https://2048-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 81.92% 81.92% +<.01%
==========================================
Files 632 632
Lines 7279 7280 +1
Branches 337 338 +1
==========================================
+ Hits 5963 5964 +1
Misses 1164 1164
Partials 152 152
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
=========================================
Coverage ? 81.85%
=========================================
Files ? 632
Lines ? 7342
Branches ? 364
=========================================
Hits ? 6010
Misses ? 1163
Partials ? 169
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add typescript: true
to the md because I think it looks pretty :)
packages/patternfly-4/react-core/src/components/Badge/Badge.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It looks very pretty. |
Fixes #1986