fix(Dropdown): handle on enter focusing when options are disabled #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PatternFly-React preview: https://2025-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2025 +/- ##
==========================================
- Coverage 82.43% 82.41% -0.03%
==========================================
Files 627 627
Lines 6951 6953 +2
Branches 119 119
==========================================
Hits 5730 5730
- Misses 1162 1164 +2
Partials 59 59
Continue to review full report at Codecov.
|
redallen
approved these changes
May 17, 2019
| @@ -39,10 +39,14 @@ class DropdownMenu extends React.Component { | |||
|
|
|||
| componentDidMount() { | |||
| if (this.props.openedOnEnter) { | |||
| if (this.props.component === 'ul') this.refsCollection[0].focus(); | |||
| const focusTarget = | |||
| this.refsCollection.filter( | |||
There was a problem hiding this comment.
In the future, you can use .find() instead of .filter()[0]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: fix for handling when options are disabled. Focus should be on the first non-disabled item.
Refer to issue: Fixes #2017