feat(Radio): Convert radio to TypeScript #1945
Conversation
|
PatternFly-React preview: https://1945-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
+ Coverage 82.33% 82.36% +0.03%
==========================================
Files 628 628
Lines 6980 6998 +18
Branches 136 143 +7
==========================================
+ Hits 5747 5764 +17
+ Misses 1161 1160 -1
- Partials 72 74 +2
Continue to review full report at Codecov.
|
|
@rebeccaalpert can you also add integration tests for this component as outlined on this README? |
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
packages/patternfly-4/react-core/src/components/Radio/Radio.tsx
Outdated
Show resolved
Hide resolved
|
Added demo/tests and addressed PR feedback. |
| @@ -0,0 +1,26 @@ | |||
| describe('Radio Demo Test', () => { | |||
| it('Navigate to demo section', () => { | |||
There was a problem hiding this comment.
Can you add some interactive test for checking and unchecking the controlled and uncontrolled buttons?
There was a problem hiding this comment.
It has one for the controlled button, but the uncontrolled buttons don't change at all HTML-wise when they're selected, so I don't know that you can write that kind of test for them.
Converted to TypeScript. I made a small change to the behavior since it was triggering a React warning related to switching from an uncontrolled to a controlled component (and back again) when you clicked the controlled radio and one about defaultChecked and checked being applied at the same time.
Fixes #1997.