fix(nav): Reverts PR #10644 that caused regression #11099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11099.surge.sh A11y report: https://patternfly-react-pr-11099-a11y.surge.sh |
kmcfaul
approved these changes
Oct 7, 2024
dlabaj
approved these changes
Oct 7, 2024
|
@dlabaj Thanks for fixing this! As this causes us quite some trouble, asking here: The 5.4.2 release happened 4 days ago already, but https://www.npmjs.com/package/@patternfly/react-core is still stuck with 5.4.1. Did something in the release go wrong? |
|
@dlabaj ah, 5.4.2 (and 5.4.8) are in the v5-prerelease channel, not "latest". This is confusing. Sorry for the noise! |
|
@martinpitt Thanks for catching this will fix the release to npm now. |
|
@martinpitt It's all set on npm now. Thanks for catching this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10897
cc @dlabaj we will want to promote a patch release for this