CodeEditor loading property considered by the Editor #11034
Conversation
|
I would like to see tests for this particular use case not being covered, I will provide as soon as we have an approval about the issue and also the proposal (this PR) |
|
Preview: https://patternfly-react-pr-11034.surge.sh A11y report: https://patternfly-react-pr-11034-a11y.surge.sh |
| @@ -652,6 +653,7 @@ class CodeEditor extends React.Component<CodeEditorProps, CodeEditorState> { | |||
| onChange={this.onChange} | |||
| onMount={this.editorDidMount} | |||
| theme={isDarkTheme ? 'vs-dark' : 'vs-light'} | |||
| loading={loading} | |||
| {...editorProps} | |||
There was a problem hiding this comment.
editorProps should already allow loading to be passed. If we want loading to be a distinct property, we will need to add it to the props table.
There was a problem hiding this comment.
I missed that this already was in the props table and is unused.
|
one more additional approver required, please any kind soul aroung? 🙏 😉 |
|
@Ginxo if you need this in v5, can you please change the base branch to the |
a new PR for V5 already open |
|
@Ginxo We are still in code freeze right now. We will merge your PR once our release is live. |
What: Closes #11033
Additional issues: