Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component - Modal Overlay #68

Closed
serenamarie125 opened this issue Nov 10, 2017 · 1 comment · Fixed by #76
Closed

Component - Modal Overlay #68

serenamarie125 opened this issue Nov 10, 2017 · 1 comment · Fixed by #76
Assignees
@priley86

Comments

@serenamarie125
Copy link
Member

Provide implementation for the modal overlay as documented here: http://www.patternfly.org/pattern-library/forms-and-controls/modal-overlay/

Note that @jeff-phillips-18 implemented this in OpenShift, but this has not yet been contributed back to Angular PatternFly (associated Issue: patternfly/angular-patternfly#673)
He has some suggestions re: implementation that should be considered.

cc: @priley86
@serenamarie125 serenamarie125 mentioned this issue Nov 10, 2017
Closed
@priley86
Copy link
Member

@serenamarie125 i've added PR #69 to start the Wizard pattern in PF React. I have setup some time next week to review this further w/ @jeff-phillips-18. thanks! :bowtie:

@priley86 priley86 self-assigned this Nov 11, 2017
This was referenced Nov 11, 2017
Closed
Merged
@jgiardino jgiardino removed the review label Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priley86 priley86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(modal) - adds the pf modal patterns priley86/patternfly-react
3 participants
@priley86 @serenamarie125 @jgiardino