Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide implementation for the Modal Overlay #673

Closed
serenamarie125 opened this issue Nov 10, 2017 · 2 comments · Fixed by #724
Closed

Provide implementation for the Modal Overlay #673

serenamarie125 opened this issue Nov 10, 2017 · 2 comments · Fixed by #724

Comments

@serenamarie125
Copy link
Member

Provide implementation for the modal overlay as documented here: http://www.patternfly.org/pattern-library/forms-and-controls/modal-overlay/

Note that @jeff-phillips-18 implemented this in OpenShift, but this has not yet been contributed back to PatternFly. Also, I think he has some suggestions re: implementation that should be considered.

@serenamarie125
Copy link
Member Author

Note: associated Issue in PatternFly React: patternfly/patternfly-react#68

@dtaylor113
Copy link
Member

Please see the Pattern design when implementing this.

This is implemented in angular-patternfly's pfWizard's outer container, meaning the title bar with 'x' close icon, the body, and the footer which contains the action buttons.

First step would be to create a skeleton new component which simply has the HTML and LESS/CSS to render the modal overview.

Next, in the new pfModalOverlay component, the title bar should be configured via some passed in JSON config obj which sets the titleText, and has a boolean to show/hide the 'x' icon (should default to 'true' if not specified). The body should be transcluded. The footer should be configured via some JSON config obj, an array of actionButtons objects with callback functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants