Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed config.json to patternlab-config.json for better consumption #282

Merged
merged 1 commit into from
Mar 7, 2016

Conversation

bmuenzenmeyer
Copy link
Member

Address #192 by renaming config.json to patternlab-config.json

bmuenzenmeyer pushed a commit that referenced this pull request Mar 7, 2016
renamed config.json to patternlab-config.json for better consumption
@bmuenzenmeyer bmuenzenmeyer merged commit 029ac93 into dev Mar 7, 2016
@bmuenzenmeyer bmuenzenmeyer deleted the 192-namespaceconfig branch March 7, 2016 07:15
@geoffp
Copy link
Contributor

geoffp commented Mar 7, 2016

nice 👍

@bmuenzenmeyer
Copy link
Member Author

Hope its not too tough to merge all this into pattern-engines. Between the builder > lib move and the whitespace cleanup and this there is certainly a lot of change a'comin'

🚀

@geoffp
Copy link
Contributor

geoffp commented Mar 7, 2016

Actually, I should go check that out now and merge dev into p-e. I did do the merge after the big whitespace cleanup and it sucked. I don't know what we'd do without all the unit tests.

@bmuenzenmeyer
Copy link
Member Author

I had some luck with git/SourceTree understanding builder/*js move. Hope it's not too rough on ya.
All baby steps toward #281 - now with an official issue cause why not

@geoffp
Copy link
Contributor

geoffp commented Mar 7, 2016

Checking out the merge situation now. I did do the merge after the big whitespace cleanup and it sucked. I don't know what we'd do without all the unit tests.

@geoffp
Copy link
Contributor

geoffp commented Mar 7, 2016

Hey, the big merge exposed a nasty bug in pattern-engines: I was doing the wrong thing with underscore-prefixed pattern files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants