-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EPIC: Implement Improved Pattern Metadata Parsing #376
Comments
- all existing tests pass - patternState and many other keys are now parsed out of pattern.md - supports pseudopatterns too #376
unit tests to coverage scenario support is only for patterns at this time, not type / subtype documentation / directories part of #376
What is the state of this? |
The above list is still accurate, with my taking potshots at different items every so often. As you can see, there is some diminishing returns as you get down the list, as we haven't fully realized a usage of some metadata - but things like |
According to the discussion on gitter we could have a discussion about if the code should store all frontmatter keys no matter of the keynames and values, or really just parse a few. I believe it would be much more flexible to just store the whole parsed markdown object into the pattern, so everyone easily can implement their own keys. |
I've implemented several of these over in the PHP version here: pattern-lab/patternlab-php-core#137 For the |
PS I've set it so |
PPS I'm passing through |
updated my issue, thanks. You can see it's a bit WIP.
we could consider making these first class citizens, not hanging them off of |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Implement the following per pattern-lab/the-spec#16
setPatternState()
from pattern_assemblerexcludeFromStyleguidenoviewall
(or a better name) out of a pattern's .md Front Matter and use to omit pattern from all renderingtags
out of a pattern's .md Front Matter and ... ??? (available in a future search enhancement?)links
out of a pattern's .md Front Matter and display in a future are of the front-endThe text was updated successfully, but these errors were encountered: