Skip to content

Commit

Permalink
rootless: drop permission check for devices
Browse files Browse the repository at this point in the history
commit 350ede1 added the feature.

Do not check whether the device is usable by the rootless user before
adding to the container.

Closes: containers#12704

[NO NEW TESTS NEEDED] it requires changes on the host to test it

Signed-off-by: Giuseppe Scrivano <[email protected]>
  • Loading branch information
giuseppe authored and patrycja-guzik committed Feb 15, 2022
1 parent 7b6b0d2 commit 3f93557
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions pkg/specgen/generate/config_linux.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,6 @@ func addPrivilegedDevices(g *generate.Generator) error {
if _, found := mounts[d.Path]; found {
continue
}
st, err := os.Stat(d.Path)
if err != nil {
if err == unix.EPERM {
continue
}
return err
}
// Skip devices that the user has not access to.
if st.Mode()&0007 == 0 {
continue
}
newMounts = append(newMounts, devMnt)
}
g.Config.Mounts = append(newMounts, g.Config.Mounts...)
Expand Down

0 comments on commit 3f93557

Please sign in to comment.